Feat/wms tile overlay#885
Open
munw37 wants to merge 6 commits intogooglemaps:feat/wms-tile-overlayfrom
Open
Conversation
…a shared source of truth. Refactored numTiles logic to use constants rather than several declarations of the same number.
…MS-dataset to forego needless network requests. If no bounds are provided the getTileUrl skips the checking and goes straight to urlFormatter. Renamed WMS_BOUND to just BOUND and added it to the comment about EARTH_CIRCUMFERENCE.
One test with xMin as a smidge above centerline (all should be null since no intersection). One test with xMax as a smidge below centerline (all should return URLs since no tile is entirely outside of bounds)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more of the functionality I described in #880