Skip to content

fix: guard against null in StreetView panorama change listeners #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balazsbarany wants to merge 1 commit into from
+4 −2
Closed

fix: guard against null in StreetView panorama change listeners #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ose/src/main/java/com/google/maps/android/compose/streetview/StreetViewPanoramaUpdater.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ internal class StreetViewPanoramaPropertiesNode(
panorama.setOnStreetViewPanoramaLongClickListener {
eventListeners.onLongClick(it)
}
// Both Java listener interfaces lack @NonNull, so GMS can deliver null. Guard the
// assignments to prevent the Kotlin compiler's implicit null-check from crashing.
panorama.setOnStreetViewPanoramaCameraChangeListener {
cameraPositionState.rawPanoramaCamera = it
it?.let { cameraPositionState.rawPanoramaCamera = it }
}
panorama.setOnStreetViewPanoramaChangeListener {
cameraPositionState.rawLocation = it
it?.let { cameraPositionState.rawLocation = it }
}
}

Expand Down