Skip to content

fix(gmail): add plain-text fallback for html send#804

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/gmail-send-html-alternative
Open

fix(gmail): add plain-text fallback for html send#804
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:fix/gmail-send-html-alternative

Conversation

@Lubrsy706
Copy link
Copy Markdown

Fixes #793.

Summary

  • Generate a text/plain alternative whenever Gmail helpers send HTML body content.
  • Keep inline-image HTML messages wrapped in multipart/related while putting a multipart/alternative body first.
  • Add coverage for gmail +send --html to verify the plain fallback is present and readable.

Testing

  • cargo fmt --check
  • cargo test -p google-workspace-cli helpers::gmail::send::tests::test_send_html_raw_message
  • cargo test -p google-workspace-cli helpers::gmail

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: 3149b59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves email deliverability and accessibility by ensuring that all HTML-based emails sent via the Gmail helper include a plain-text version. It introduces a lightweight utility to strip HTML tags and decode basic entities, ensuring that recipients who cannot render HTML still receive the message content.

Highlights

  • Plain-text fallback: Implemented a basic HTML-to-plain-text converter to ensure emails sent as HTML include a text/plain alternative for better compatibility.
  • Message structure: Updated the Gmail message builder to wrap HTML content in a multipart/alternative structure, while maintaining support for multipart/related when inline images are present.
  • Testing: Added assertions to existing tests to verify that the generated email structure correctly includes the new plain-text fallback.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label May 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a plain text fallback for HTML emails sent via Gmail. It adds logic to finalize_message to generate a text/plain version of the HTML body using new helper functions html_to_plain_text and decode_basic_html_entities. This ensures better compatibility with email clients that do not support HTML. Test cases were also updated to verify the inclusion of the multipart/alternative structure and plain text content. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gmail +send --html should emit multipart/alternative (parity with +reply-all)

2 participants