fix(gmail): add plain-text fallback for html send#804
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves email deliverability and accessibility by ensuring that all HTML-based emails sent via the Gmail helper include a plain-text version. It introduces a lightweight utility to strip HTML tags and decode basic entities, ensuring that recipients who cannot render HTML still receive the message content. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a plain text fallback for HTML emails sent via Gmail. It adds logic to finalize_message to generate a text/plain version of the HTML body using new helper functions html_to_plain_text and decode_basic_html_entities. This ensures better compatibility with email clients that do not support HTML. Test cases were also updated to verify the inclusion of the multipart/alternative structure and plain text content. I have no feedback to provide.
Fixes #793.
Summary
gmail +send --htmlto verify the plain fallback is present and readable.Testing
cargo fmt --checkcargo test -p google-workspace-cli helpers::gmail::send::tests::test_send_html_raw_messagecargo test -p google-workspace-cli helpers::gmail