Skip to content

hack: return start function for embedded start #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedadams merged 1 commit into from
May 22, 2026
Merged

hack: return start function for embedded start #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/sdkserver/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,24 @@ func Run(ctx context.Context, opts Options) error {

// EmbeddedStart allows running the server as an embedded process that may use Stdin for input.
// It returns the address the server is listening on.
func EmbeddedStart(ctx context.Context, options ...Options) (string, error) {
func EmbeddedStart(ctx context.Context, options ...Options) (string, func(), error) {
opts := complete(options...)

listener, err := newListener(opts)
if err != nil {
return "", err
return "", nil, err
}

start := make(chan struct{})

go func() {
_ = run(ctx, listener, opts)
<-start
if err := run(ctx, listener, opts); err != nil {
log.Fatalf("server error: %v\n", err)
}
}()

return listener.Addr().String(), nil
return listener.Addr().String(), func() { close(start) }, nil
}

func (s *server) close() {
Expand Down
Loading