Skip to content

Fixes to profiler selection logic. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whatdhack wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes to profiler selection logic. #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32cf892
Fixes to profiler selection logic.
Nov 17, 2025
5a2c242
Merge branch 'gpu-mode:main' into main
whatdhack Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions problems/nvidia/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def run_single_profile(test: TestCase, pool: multiprocessing.Pool) -> str:
"""
Runs a single profiling activity in another process.
"""
if bool(os.getenv("POPCORN_NCU", "0")):
if int(os.getenv("POPCORN_NCU", "0")) == 1:
Copy link
Member

@msaroufim msaroufim Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late review, did you manage to test this is the problem locally and verify this fixes things? I can test just in between too many open terminals right now lol

FWIW the eval we're using is better_eval.py

return pool.apply(_run_single_profile_ncu, (test,))
else:
return pool.apply(_run_single_profile_torch, (test,))
Expand All @@ -420,7 +420,8 @@ def run_profiling(
report = run_single_profile(test, pool)
logger.log(
f"benchmark.{idx}.report",
base64.b64encode(report.encode("utf-8"), b"+*").decode("utf-8"),
#base64.b64encode(report.encode("utf-8"), b"+*").decode("utf-8"),
report
)
logger.log("check", "pass")
return 0
Expand Down