runner: allow to create plugin-specific exceptions at rule level #496
+118
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
academo
commented
Jan 28, 2026
| ResultOf: make(map[*analysis.Analyzer]any), | ||
| } | ||
|
|
||
| pass.Report = func(ruleName string, d analysis.Diagnostic) { |
Collaborator
Author
There was a problem hiding this comment.
I moved this outside to have access to pass in the closure.
academo
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
xnyo
approved these changes
Jan 28, 2026
pkg/runner/runner.go
Outdated
Comment on lines
65
to
66
| for _, exceptedPluginID := range ruleConfig.Exceptions { | ||
| if exceptedPluginID == pluginId { |
Member
There was a problem hiding this comment.
Nit: can probably use slices.Contains here: https://pkg.go.dev/slices#Contains
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #457
This PR allows to configure exceptions for specific rules for specific plugins id
This feature is a complement to the existing exceptions at a validator level but with better granularity
e.g. you want the coderules analyzer to run but only ignore specific rules for your plugin