update react, typescript and jest#84
Merged
oleksiilevzhynskyi merged 9 commits intogrammarly:masterfrom Sep 9, 2022
opudalo:update-deps
Merged
update react, typescript and jest#84oleksiilevzhynskyi merged 9 commits intogrammarly:masterfrom opudalo:update-deps
oleksiilevzhynskyi merged 9 commits intogrammarly:masterfrom
opudalo:update-deps
Conversation
Contributor
|
Hi @opudalo. Thank you for your contribution! A bit of context for React 18 and Focal. Focal still use the old lifecycle API. It's not a blocker, but this isn't compatible with React async mode in Suspense. @KatSick working on migration (#82) Anyway, your PR looks ok to me. Going to double-check if it works on my side and release it in a few days or so. |
Contributor
Author
|
Hello guys, any update on this? |
oleksiilevzhynskyi
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.