restore xaxs/yaxs on.exit if necessary#546
Merged
vincentarelbundock merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Collaborator
|
Thanks! I reviewed the changes and they are very clean and straightforward, so will merge now. I just added a simple snapshot test with a title so we can easily know what to look for in the snapshot. |
Collaborator
|
and a news item |
Collaborator
Author
|
Cool, Vincent, thanks a lot! 🚀 I was too tired yesterday... |
Owner
|
Thanks both! I know there are a couple of other new PRs to look at. I'm hoping to get time closer to the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545
If
yaxsand/orxaxsare set indraw_facet_window()they are now retored to their previous values. This fixes the behavior of the examples from the issue.Note that there is no clipping anymore of the first/last point in the scatterplot.