Extract reentry helper ownership from lowering#1506
Merged
Conversation
c0206b8 to
d28d660
Compare
d28d660 to
e90c041
Compare
This was referenced May 17, 2026
perf: graphistry wheel size (625 kB) — GFQL engine files are large, investigate modularization
#1058
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1497.
graphistry.compute.gfql.cypher.loweringintographistry.compute.gfql.cypher.reentry.lowering_support.CHANGELOG.md.Validation
python3 -m compileall -q graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql/cypher/reentrypython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering_s3_split_guard.py graphistry/tests/compute/gfql/cypher/test_lowering.py -k "(reentry or bounded or carry or alias) and not cudf"->277 passed, 804 deselected./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql/cypher/reentry graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/cypher/test_lowering_s3_split_guard.py./bin/typecheck.sh->Success: no issues found in 264 source filespython3 bin/ci_cypher_surface_guard.pygit diff --checkreentry.helpersmodule toreentry.lowering_support; repeated compileall, focused pytest, ruff, typecheck, surface guard, and diff check locally.gh pr checks 1506 --repo graphistry/pygraphistry --watch-> green again ond28d6606after the naming-only rename; includestck-gfql,test-docs, andtest-full-ai.c0206b8e:2404 passed, 22 skipped, 15 xfailed(/tmp/pygraphistry-1497-dgx/rapids-25.02-gfql-c0206b8e.log); follow-upd28d6606is naming-only and locally revalidated.c0206b8e:2404 passed, 22 skipped, 15 xfailed(/tmp/pygraphistry-1497-dgx/rapids-26.02-gfql-c0206b8e.log); follow-upd28d6606is naming-only and locally revalidated.Local cuDF-focused run was attempted first, but this shell has
cudfinstalled without a CUDA device, so cuDF tests fail atcudaErrorNoDevicebefore exercising this change. DGX 25.02/26.02 full GFQL is green.Review
Coordination
origin/masterafter fix(cypher): disambiguate IC4 HAS_TAG endpoints #1502 and chore(gfql): remove unused cypher lowering helper #1500 landed.