Added gfcc_updater_cache_ttl for adjusting the Github updater cache TTL.#10
Merged
Merged
Conversation
🪝 Hook Documentation ChangesThis PR contains changes to hook documentation: Summary:
🆕 New Hooks
This comment is automatically updated when new commits are pushed to this PR. |
veryspry
reviewed
Mar 9, 2026
Collaborator
veryspry
left a comment
There was a problem hiding this comment.
@SebastianWiz I wonder if we should apply the filter from the plugin itself to increase the TTL by default. Five minutes does seem fairly aggressive. 🤔
veryspry
approved these changes
Mar 9, 2026
Collaborator
veryspry
left a comment
There was a problem hiding this comment.
@SebastianWiz Whoops, forgot to approve.
My comment about increasing TTL by default is optional and definitely something we could wait on doing until (if) we get more reports about this.
Contributor
Author
|
@veryspry Yeah lets keep an eye on it, I'm surprised it haven't come up before! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/3248978245/98934?viewId=3808239
Summary
This PR adds a new filter,
gfcc_updater_cache_ttl, that allows users to override the default 5-minute GitHub updater release metadata cache TTL without editing the bundled updater library.Checklist