Skip to content

Added gfcc_updater_cache_ttl for adjusting the Github updater cache TTL.#10

Merged
SebastianWiz merged 1 commit into
mainfrom
seb/add/98934-updater-cache-ttl
Mar 10, 2026
Merged

Added gfcc_updater_cache_ttl for adjusting the Github updater cache TTL.#10
SebastianWiz merged 1 commit into
mainfrom
seb/add/98934-updater-cache-ttl

Conversation

@SebastianWiz
Copy link
Copy Markdown
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3248978245/98934?viewId=3808239

Summary

This PR adds a new filter, gfcc_updater_cache_ttl, that allows users to override the default 5-minute GitHub updater release metadata cache TTL without editing the bundled updater library.

Checklist

  • Updated customer telling them that a fix/addition is in the works.
  • Added/Improved Cypress tests or a note under Summary why tests are not included in the PR.
  • Added a link to this PR in the Help Scout ticket(s) in the form of a note
  • Added/updated hook documentation if applicable.
  • Sent a packed build of this PR/branch for the customer to test.

@gravitywiz-builder
Copy link
Copy Markdown

🪝 Hook Documentation Changes

This PR contains changes to hook documentation:

Summary:

  • 🆕 1 new hooks
  • ✏️ 0 modified hooks
  • 🗑️ 0 removed hooks

🆕 New Hooks

  • gfcc_updater_cache_ttl (gf-code-chest) - ⚠️ Undocumented

This comment is automatically updated when new commits are pushed to this PR.

Copy link
Copy Markdown
Collaborator

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianWiz I wonder if we should apply the filter from the plugin itself to increase the TTL by default. Five minutes does seem fairly aggressive. 🤔

Copy link
Copy Markdown
Collaborator

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianWiz Whoops, forgot to approve.

My comment about increasing TTL by default is optional and definitely something we could wait on doing until (if) we get more reports about this.

@SebastianWiz
Copy link
Copy Markdown
Contributor Author

@veryspry Yeah lets keep an eye on it, I'm surprised it haven't come up before!

@SebastianWiz SebastianWiz merged commit f1b9286 into main Mar 10, 2026
2 checks passed
@SebastianWiz SebastianWiz deleted the seb/add/98934-updater-cache-ttl branch March 10, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants