Fix FLARE_OPERATOR_PORT parsing: replace atoi with strtol + range validation#141
Draft
Copilot wants to merge 3 commits intoflare-operatorfrom
Draft
Fix FLARE_OPERATOR_PORT parsing: replace atoi with strtol + range validation#141Copilot wants to merge 3 commits intoflare-operatorfrom
Copilot wants to merge 3 commits intoflare-operatorfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Open
Co-authored-by: junjihashimoto <2469618+junjihashimoto@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on the Flare operator pull request
Fix FLARE_OPERATOR_PORT parsing: replace atoi with strtol + range validation
Mar 15, 2026
af5e28d to
edc951d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLARE_OPERATOR_PORTwas parsed withatoi, which silently returns0on invalid input and has no range validation — allowing an invalid port to reachindex_server_portwithout any diagnostic.Changes
src/flared/flared.ccatoiwithstrtol+ full error detection (errno,endptr, trailing-char check)[1, 65535]; emitlog_warningand skip override on invalid inputport_val; reusestatic_cast<int>(port_val)for boths.index_server_portand thelog_noticeline<cerrno>to theENABLE_K8S_OPERATORinclude guard✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.