fix: coerce chunk ids to string before comparison#1035
Open
panbenson wants to merge 1 commit into
Open
Conversation
Webpack can assign numeric chunk ids, which causes strict equality checks to fail when compared against string values. Coerce all chunk id values with String() before comparison in ChunkExtractor and loadableReady. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
@theKashey could you please take a look at this? |
|
The workaround is to set the rspack config setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upon bumping to Rspack V2, projects using loadable become unresponsive/stuck in loading. Rspack V2 switched to numeric chunk ids in production by default, which is being documented on the migration guide in web-infra-dev/rspack#13839
Numeric chunk ids cause strict equality (
===) comparisons inChunkExtractorandloadableReadyto silently fail against string values. This PR proposes fixing it by coercing all chunk IDs to strings withString()before comparison.Test plan
Added unit tests for changes, I've also verified manually by applying the diff to my project as well.