Replacing outdated WebSocket with ws4py#8
Open
remram44 wants to merge 1 commit intogregmuellegger:masterfrom
Open
Replacing outdated WebSocket with ws4py#8remram44 wants to merge 1 commit intogregmuellegger:masterfrom
remram44 wants to merge 1 commit intogregmuellegger:masterfrom
Conversation
Owner
|
This looks really good! Thanks for your efforts! I hope to find time to integrate these changes -- but before I can merge them, they need some tests. The current test suite won't run. |
|
Is there any chance this will get integrated? I've been playing for a while with that code. I can't say if it's successful since I don't know that much about sockets yet. I've been using Arduino to get data into the Raspberry PI where I'm having a stack made from nginx, circus, chaussette, ws4py, gevent, zmq and django. Right now it sends data to the client, but I didn't try to send data from the browser back to the server yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feels hacky (but works).
Instead of reimplementing the RFC, I used ws4py's implementation.
This needs extensive testing. I'm also not content with the dup() call, there must be a way to prevent Django from fiddling with the socket...