Fixes #4: CLI parser can accept "--flag value" arguments #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of splitting the command-line on whitespace, and looking for "--flag=value" strings to find the flags, step through all the arguments to that "--flag=value" and "--flag value" (as separate arguments) can be handled. This also adds the convention seen in many POSIX tools whereby the "--" string stops optional flag processing, and everything after it is considered a positional argument. This implementation does not allow separated values that start with "--", as in "--output --legal-filename". That produces an error. If the user really wants to do that, they can use the version with the equals sign: "--output=--legal-filename"
Contributor
Author
|
The one "code smell" here is that instead of adding a notion of "does this flag require a value", I'm keying off of the "title" field in the FlagParserDescription. A toggle flag has an empty title, whereas non-toggle flags do not. If we want to improve that, FlagParserDescription should change. I added new unit tests, which pass. I am unable to build a gren 0.6.3 compiler with this package, however. |
Member
|
Yeah, the compiler app hasn't been updated to the latest version of Gren, so unit tests will have to do for now :) |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of splitting the command-line on whitespace, and looking for "--flag=value" strings to find the flags, step through all the arguments to that "--flag=value" and "--flag value" (as separate arguments) can be handled.
This also adds the convention seen in many POSIX tools whereby the "--" string stops optional flag processing, and everything after it is considered a positional argument.
This implementation does not allow separated values that start with "--", as in "--output --legal-filename". That produces an error. If the user really wants to do that, they can use the version with the equals sign: "--output=--legal-filename"