A114: WRR Support for Custom Backend Metrics#536
A114: WRR Support for Custom Backend Metrics#536sauravzg wants to merge 6 commits intogrpc:masterfrom
Conversation
sauravzg
force-pushed
the
wrr-custom-metrics
branch
3 times, most recently
from
1423c95 to
6ed9125
Compare
sauravzg
force-pushed
the
wrr-custom-metrics
branch
from
6ed9125 to
19efcc0
Compare
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
This looks really good! I have just a few minor comments.
Please let me know if you have any questions. Thanks!
| // By default, utilization is computed by taking the max of the values of the | ||
| // metrics specified here. If none of the specified metrics are present in the | ||
| // load report (or if this field is empty, or all values are less than or | ||
| // equal to 0), the policy will fall back to using 'application_utilization' |
There was a problem hiding this comment.
What do these two strings mean? It wasn't actually defined in this comment. If this comment describes the behavior to our users, then it needs to say something about it.
There was a problem hiding this comment.
Rephrased to hide implementation details by referring to "existing default behavior". Resolving this comment in favor of the previous one.
There was a problem hiding this comment.
I was actually arguing that we should define what the strings here mean. Anyone who sets it will need to know that. So changing "metric names" to "metrics" is a step in the wrong direction.
"Implementation details" is a weird way of putting it, as users are expected to know what that behavior is. I can understand not wanting to define it here but it is not a goal to hide that information.
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Just one minor nit remaining, otherwise looks good from my end!
|
@ejona86 PTAL if we are okay to move forward with submitting this. |
| // By default, utilization is computed by taking the max of the values of the | ||
| // metrics specified here. If none of the specified metrics are present in the | ||
| // load report (or if this field is empty, or all values are less than or | ||
| // equal to 0), the policy will fall back to using 'application_utilization' |
There was a problem hiding this comment.
I was actually arguing that we should define what the strings here mean. Anyone who sets it will need to know that. So changing "metric names" to "metrics" is a step in the wrong direction.
"Implementation details" is a weird way of putting it, as users are expected to know what that behavior is. I can understand not wanting to define it here but it is not a goal to hide that information.
5 participants
This proposal allows configuring the weighted_round_robin policy to use custom backend metrics (via ORCA) for computing endpoint weights, instead of relying solely on standard utilization metrics. This aligns gRPC with xDS custom backend metric support.