Conversation
|
@marjisound has published a preview version of this PR with release workflow run #12, based on commit 341c11e: 11.0.0-PREVIEW.update-content-api-models.2025-01-07T1757.341c11e5 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the update-content-api-models branch, or use the GitHub CLI command: gh workflow run release.yml --ref update-content-api-models Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
|
@marjisound has published a preview version of this PR with release workflow run #13, based on commit 6e4f988: 11.0.0-PREVIEW.update-content-api-models.2025-01-08T1653.6e4f988c Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the update-content-api-models branch, or use the GitHub CLI command: gh workflow run release.yml --ref update-content-api-models Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
|
@marjisound has published a preview version of this PR with release workflow run #14, based on commit e445003: 11.0.0-PREVIEW.update-content-api-models.2025-01-10T1154.e4450031 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the update-content-api-models branch, or use the GitHub CLI command: gh workflow run release.yml --ref update-content-api-models Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
| with: | ||
| node-version-file: .nvmrc | ||
| registry-url: https://registry.npmjs.org | ||
| - uses: sbt/setup-sbt@v1.1.0 |
There was a problem hiding this comment.
The runner latest version doesn't seem to have sbt anymore. We have to install sbt ourselves. This is happening in other repos too. e.g. https://github.com/guardian/content-api-scala-client/blob/7fbcead38ad66108c50448f53bcea00b2a309474/.github/workflows/ci.yml#L23
3 participants
What does this change?
This PR updates
content-api-modelsto26.0.0.In PR #98 multiple updates were introduced, but conflicts arose during the process. To make troubleshooting easier, I’m splitting those updates into smaller, more focused sub-updates, starting with this one.
How to test
I published a snapshot version in both sonatype and npm
11.0.0-PREVIEW.update-content-api-models.2025-01-08T1653.6e4f988cThis changes was tested by making the following updates in MAPI and AR:
I ran MAPI and AR locally. I tested a few articles through
rendered-itemendpoint in MAPI and made sure this endpoint is pointing to local AR rather than the prod one. e.g. http://localhost:9000/uk/rendered-items/society/2025/jan/08/tories-push-for-new-grooming-inquiry-child-safety-bill-bridget-phillipsonI also tweaked
RenderingPlatformPickerin MAPI to give priority to AR rather than DCR. This way, I could AR test articles in the apps.