Open
Conversation
scrooge-extras library has recently got typescript issues fixed and gha-scala-workflow release process implemented. This will test those changes. ref:
Member
|
This looks to be failing due to the fix for twitter/scrooge#259 - twitter/scrooge@884f360 - which banned keywords like We need to work out if it is at all possible to rename the thrift fields without breaking... everything. In Ophan we were able to rename several Thrift fields that we wanted to mark as obsolete - see eg https://github.com/guardian/ophan/pull/4162 - but I'm not sure if in the content api, there is any reliance on the fields exactly matching the name used in the Elasticsearch schema... |
Contributor
|
Mentioning https://github.com/guardian/content-api/commit/56f7c0b5c2c43a16f5f620dbce109540a71dfcf1 here for cross-referencing: it’s a commit I made a while ago in CAPI downgrading scrooge to 21.8.0 to avoid this reserved words problem. |
emdash-ie
added a commit
to guardian/fezziwig
that referenced
this pull request
Oct 21, 2024
We use some thrift reserved words in our thrift definitions, and as of [scrooge version 21.9.0](https://github.com/twitter/scrooge/releases/tag/scrooge-21.9.0), scrooge throws errors when it encounters these reserved words. Until we’ve worked out how to get around this problem, this commit configures Scala Steward not to update scrooge past the version we’re currently on (21.8.0). For more information, see: - guardian/content-api#2903 - guardian/content-api-models#231
This was referenced Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
scrooge-extras library has recently got typescript issues fixed and gha-scala-workflow release process implemented. This will test those changes.
How to test
sbt testHow can we measure success?
tests locally are passing.
apple-news to test with.