Skip to content

Remove deprecated 'fixed' containers #15500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domlander wants to merge 1 commit into
base: main
Choose a base branch
from
+88 −2,685
Open

Remove deprecated 'fixed' containers #15500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions dotcom-rendering/fixtures/manual/frontCollections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const defaultGrouped = {

const defaultValues = {
backfill: [],
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
Copy link
Contributor Author

@domlander domlander Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed/small/slow-IV & fixed/small/slow-V-mpu most closely resemble static/medium/4 in the new world. All the others are most similar to the flexible flexible/general container.

See: Chromatic for visuals

config: {
showDateHeader: false,
},
Expand All @@ -35,13 +35,13 @@ export const testCollectionsUk = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'LongRunningAltPalette',
displayName: 'Ukraine invasion',
},
{
...defaultValues,
collectionType: 'fixed/small/slow-V-mpu',
collectionType: 'static/medium/4',
displayName: 'News extra',
},
{
Expand Down Expand Up @@ -71,12 +71,12 @@ export const testCollectionsUk = [
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Lifestyle',
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VII',
collectionType: 'flexible/general',
displayName: 'Culture',
},
{
Expand All @@ -91,7 +91,7 @@ export const testCollectionsUk = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
displayName: 'The rural network',
},
{
Expand All @@ -111,23 +111,23 @@ export const testCollectionsUk = [
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Multimedia',
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'Branded',
displayName: 'Guardian Labs',
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-XII-mpu',
collectionType: 'flexible/general',
displayName: 'Explore',
},
{
...defaultValues,
collectionType: 'fixed/small/slow-I',
collectionType: 'flexible/general',
displayName: 'The big picture',
},
{
Expand Down Expand Up @@ -162,7 +162,7 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
displayName: 'In depth',
},
{
Expand All @@ -172,13 +172,13 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'LongRunningAltPalette',
displayName: 'Ukraine invasion',
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Opinion',
},
{
Expand All @@ -193,7 +193,7 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
displayName: 'Climate crisis',
},
{
Expand All @@ -218,7 +218,7 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VII',
collectionType: 'flexible/general',
displayName: 'Podcasts',
},
{
Expand All @@ -228,28 +228,28 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Culture',
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'Branded',
displayName: 'Business briefs',
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Lifestyle',
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
displayName: 'Take part',
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'Explore',
},
{
Expand All @@ -259,7 +259,7 @@ export const testCollectionsUs = [
},
{
...defaultValues,
collectionType: 'fixed/medium/slow-VI',
collectionType: 'flexible/general',
displayName: 'In pictures',
},
{
Expand All @@ -282,7 +282,7 @@ export const brandedTestCollections = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'Branded',
displayName: 'Guardian Labs',
},
Expand All @@ -293,7 +293,7 @@ export const brandedTestCollections = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'Branded',
displayName: 'Guardian Labs',
},
Expand All @@ -304,7 +304,7 @@ export const brandedTestCollections = [
},
{
...defaultValues,
collectionType: 'fixed/small/slow-IV',
collectionType: 'static/medium/4',
containerPalette: 'Branded',
displayName: 'Guardian Labs',
},
Expand Down
143 changes: 0 additions & 143 deletions dotcom-rendering/src/components/DecideContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,6 @@ import type {
DCRFrontCard,
DCRGroupedTrails,
} from '../types/front';
import { FixedLargeSlowXIV } from './FixedLargeSlowXIV';
import { FixedMediumFastXI } from './FixedMediumFastXI';
import { FixedMediumFastXII } from './FixedMediumFastXII';
import { FixedMediumSlowVI } from './FixedMediumSlowVI';
import { FixedMediumSlowVII } from './FixedMediumSlowVII';
import { FixedMediumSlowXIIMPU } from './FixedMediumSlowXIIMPU';
import { FixedSmallFastVIII } from './FixedSmallFastVIII';
import { FixedSmallSlowI } from './FixedSmallSlowI';
import { FixedSmallSlowIII } from './FixedSmallSlowIII';
import { FixedSmallSlowIV } from './FixedSmallSlowIV';
import { FixedSmallSlowVHalf } from './FixedSmallSlowVHalf';
import { FixedSmallSlowVMPU } from './FixedSmallSlowVMPU';
import { FixedSmallSlowVThird } from './FixedSmallSlowVThird';
import { FlexibleGeneral } from './FlexibleGeneral';
import { FlexibleSpecial } from './FlexibleSpecial';
import { Island } from './Island';
Expand Down Expand Up @@ -61,136 +48,6 @@ export const DecideContainer = ({
containerLevel,
}: Props) => {
switch (containerType) {
case 'fixed/large/slow-XIV':
return (
<FixedLargeSlowXIV
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-IV':
return (
<FixedSmallSlowIV
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-V-mpu':
return (
<FixedSmallSlowVMPU
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-III':
return (
<FixedSmallSlowIII
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-I':
return (
<FixedSmallSlowI
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-V-third':
return (
<FixedSmallSlowVThird
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/slow-V-half':
return (
<FixedSmallSlowVHalf
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/medium/slow-VI':
return (
<FixedMediumSlowVI
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/medium/slow-VII':
return (
<FixedMediumSlowVII
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/medium/slow-XII-mpu':
return (
<FixedMediumSlowXIIMPU
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/medium/fast-XII':
return (
<FixedMediumFastXII
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/medium/fast-XI':
return (
<FixedMediumFastXI
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'fixed/small/fast-VIII':
return (
<FixedSmallFastVIII
trails={trails}
containerPalette={containerPalette}
showAge={showAge}
serverTime={serverTime}
imageLoading={imageLoading}
/>
);
case 'nav/list':
return <NavList trails={trails} showImage={false} />;
case 'nav/media-list':
Expand Down
34 changes: 0 additions & 34 deletions dotcom-rendering/src/components/FixedLargeSlowXIV.stories.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading