Implement Terminal.Gui.Cli core library API#3
Conversation
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/90f515f0-dbc5-4dc5-b941-ecd32f33b83f Co-authored-by: tig <585482+tig@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/90f515f0-dbc5-4dc5-b941-ecd32f33b83f Co-authored-by: tig <585482+tig@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0831a5de5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@copilot see cr feedback. Write tests that fail for each before fixing. |
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/65752f23-da62-481d-898c-b455cb3e3afa Co-authored-by: tig <585482+tig@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/65752f23-da62-481d-898c-b455cb3e3afa Co-authored-by: tig <585482+tig@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/65752f23-da62-481d-898c-b455cb3e3afa Co-authored-by: tig <585482+tig@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/65752f23-da62-481d-898c-b455cb3e3afa Co-authored-by: tig <585482+tig@users.noreply.github.com>
|
@copilot see review comments and address. Verify ci/cd uses the same code formatting/style check infrastructure)including running resharper cleanup. These issues should have caused the workflows in this pr to fail. |
Agent-Logs-Url: https://github.com/gui-cs/cli/sessions/9e373df4-deb3-46a7-963e-8161efc70256 Co-authored-by: tig <585482+tig@users.noreply.github.com>
Addressed in 73eaae9. I ran ReSharper cleanup, committed the resulting style fixes, pinned JetBrains ReSharper GlobalTools, and updated CI/release workflows to run cleanupcode plus dotnet format and fail on diffs. Local restore/build/format/tests and CodeQL/code review validation passed; the new GitHub CI run is awaiting action before jobs are created. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
- GreetCommand: input command with --formal per-command option - InfoCommand: viewer command with --cat support - Embedded agent-guide.md resource wired via CliHostOptions - Program.cs wires CliHost with commands and agent-guide - Fix ArgParser two-pass bug: first parse (no command) now skips unknown options after alias so the second pass validates them Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove redundant 'using Terminal.Gui.Cli' (implicit via namespace) - Use target-typed new for CommandOptionDescriptor Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Document the CI style-check pipeline (jb cleanupcode + dotnet format) - Add pre-commit verification steps agents must run - Add coding standards for target-typed new() and redundant usings - Update project status from 'scaffolding' to library description Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Terminal.Gui.Clineeds a reusable host layer for Terminal.Gui-backed commands: explicit command registration, typed results, stable JSON output, POSIX exit codes, help metadata, and AI-agent discoverability.Command API
CommandRegistrywith case-insensitive alias resolution and duplicate rejection.Host and parsing
CliHost,CliHostOptions,CommandRunOptions, andArgParser.CliHost.--cat,--json, and output routing.Output and metadata
JsonEnvelope,ResultWriter,ExitCodes,TypeNames, andOpenCliWriter.Built-ins and docs
help, andagent-guide.specs/.Tests
Example: