refactor/elimination of MultisliceCalculator._process_frame_worker_torch, and probe.array expansion for decoherence#50
Merged
tpchuckles merged 22 commits intomainfrom Jan 10, 2026
Merged
Conversation
…compatible, ensuring 18_caching test still passes
…coherence applyShifts, new example 19_coherence.py in tests.
Simplify calculator worker2
…potentials torch save/load
…dle varying shapes down the line....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two major chances were introduced to dev via PRs #39 and #41, but not all tests pass.
all tests now pass, so i vote they go into main, with or without an increment to the minor version and a new release (there is only one specific person i know who is looking for the decoherence changes, so a new version is not a huge deal)
to check tests, check out tests/runAllTests-*.log. there should be one each for numpy, torchcpu, and torchgpu, and the only error should be lacbed_iterative, which has never match lacbed_onthefly.