Add shared comments for disbursements

[albertchae]

Summary of the problem

https://hackclub.slack.com/archives/C026RKHLPNJ/p1773163261567279

Previously, since we had a single HcbCode for disbursements, comments were always shared. Now they can be on either side of the disbursement, but we still want the ability to share comments selectively.

Describe your changes

Since both sides of a disbursement still have a connection to the Disbursement, we are adding Commentable to that model.

It was unavoidable to add shared comment specific methods to HcbCode but we tried to delegate them to models that make more sense as much as possible (e.g. shared_comment_recipient_label lives on ingoing/outgoing disbursements)

• Switch from hardcoded redirect to redirect_back_or_to since it is exactly for the case we want to handle. Redirect to the original commentable as a fallback because we don't want to redirect to a Disbursement on a shared comment vs the HcbCode that the comment is originating from.
• Add all_comments to Commentable that aggregates comments from both the primary commentable and its shared_commentable. Currently it doesn't own ordering because that's already handled in the view, but we should probably push that to the model
• UI shows all comments on your side and shared comments, interleaved by created_at (post time). For the checkbox we show the name of the other. Added some styling to shared comments similar to admin comments. side, but for created comments we can't since they are only stored on the shared Disbursement model and it's possible the author has access to both sides of the disbursement.
• Minor refactor of HcbCode#disbursement? to use existing predicate methods

[garyhtou]

Here's another approach we can try:

• Add a select dropdown on the frontend.
  • Can be implemented as a dropdown button (GitHub style)
• Depending on the selected option, it will set a few form fields:
  • commentable_type and commentable_id
  • return_to (this is where the controller redirects after the POST)
    • In practice, this will just be an HcbCode URL (the url of the page which the form is being rendered)
• controller would only need to be updated to handle return_to
  • redirect_back_or_to url_from(return_to) || @commentable

[garyhtou]

Yeah, let's implement Disbursement#events so that it uses the first case in this if statement and includes ancestor_users

[garyhtou]

This code is buggy

[garyhtou]

Double check whether ancestor_users already includes users

[garyhtou]

Feedback from call:

• Remove red styling for "shared comments". Shared comments shouldn't affect the comment card border.
• Keep the "shared with X" on the top right of the comment card, but polish up the styling
• On the Disbursement show page, list comments from all three commentables (Disbursement, Outgoing Disbursement, Incoming Disbursement)
• On the Disbursement show page, the "Add comment" form adds the comment to the Disbursement commentable. The "Add comment" button should make it extremely clear that you're adding to both sides.
  • We will not add the option to select a commentable right now (no choice between Disbursement, Outgoing Disbursement, Incoming Disbursement). The only option for commentable is the Disbursement.
• On each transaction, the other transaction contains comments, which means there are comments not visible on the current page. Add a link to view all comments.
  • Example: Outgoing disbursement has 2 comments, Disbursement has 3 comments, Incoming disbursement has 4 comments. On the outgoing disbursement show page it says "View 4 other comments" and links to the Disbursement show page. On the incoming disbursement, it says "View 2 other comments" and links to the disbursement show page.

[albertchae]

• fix showing the shared with label across incoming/outgoing vs the main disbursement
• move view other side link to below bottom comment and above text box

[github-actions]

Suggested change

	@hcb_code.outgoing_disbursement.disbursement.incoming_disbursement.local_hcb_code
	else
	@hcb_code.incoming_disbursement.disbursement.outgoing_disbursement.local_hcb_code
	end %>
	@hcb_code.outgoing_disbursement.disbursement.incoming_disbursement.local_hcb_code
	else
	@hcb_code.incoming_disbursement.disbursement.outgoing_disbursement.local_hcb_code
	end %>