[v4] Return client secret on Payment Intent creation#13295
Draft
Mohamad-Mortada wants to merge 2 commits intomainfrom
Draft
[v4] Return client secret on Payment Intent creation#13295Mohamad-Mortada wants to merge 2 commits intomainfrom
Mohamad-Mortada wants to merge 2 commits intomainfrom
Conversation
garyhtou
requested changes
Apr 2, 2026
Comment on lines
37
to
40
| amount = params[:amount_cents] | ||
| donation_id = params[:donation_id] | ||
| if params[:fee_covered] && @event.config.cover_donation_fees | ||
| amount /= (1 - @event.revenue_fee).ceil |
Member
There was a problem hiding this comment.
Instead of taking in these parameters here, we should pull them off the donation that was already created
| @@ -35,6 +35,7 @@ def create | |||
|
|
|||
| def payment_intent | |||
Member
There was a problem hiding this comment.
Make this a member route instead of collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Needed to process the payment intent on the mobile app
Describe your changes
returns client secret of that payment intent