Port Slack Events Bot into Laravel#570
Conversation
cd36c16 to
0a93a1e
Compare
|
After chatting with @irby, we should probably hash+salt the access tokens like user passwords, and then I think we still need to implement the check_api action to happen automatically every hour, I'll probably do more of that later. However, if someone else has a test setup they're welcome to message me and push to my branch! |
|
I had a brain fart, we're probably not going to want to hash the access token, I'll probably just remove that table later since I don't think we're going to need it for anything |
|
So turns out the current implementation working in our workspace might've been a bit misleading, since we were relying on our bot token rather than the installation-specific tokens to access the Slack API. Even though it was working in my testing, I think we need to actually use the installation-specific access tokens for each installation otherwise it would break for other installations, so I need to test this with my current implementation as well. I'm currently trying to get the tests to pass and this should be ready after that I think |
0be5cf7 to
0f7f19e
Compare
|
All the unresolved comments are items that I still need to get to with this PR (or that someone else can get to), but I'll hopefully get to these soon |
irby
left a comment
There was a problem hiding this comment.
Code-wise I'm fine with everything here.
f28602a to
df68940
Compare
|
Bogdan has a production server running on Railway that we're going to be testing. The main thing that I could see holding us up is that we're currently proxying /slack paths for the Slack bot to the localhost container on my old server. I'm sure we could figure how to temporarily proxy that through a sub-domain, but this PR already aimed to just do away with the Python implementation in favor of built in PHP. I provided comments on documentation, but I hoped to see if you'd have time to get this one over the finish line if there's anything remaining to be done. |
|
I just started paying for the fancy claude code, so I can update this branch and get it in tip top shape soon, but I have some other stuff that I need to get done first |
|
@oliviasculley great, I am putting this into Draft mode, let me know if you need any help! |
aa2d970 to
1d76b2f
Compare
|
@bogdankharchenko I think this might be ready now! |
a80e53f to
87b1a12
Compare
87b1a12 to
72c7438
Compare
48892c8 to
36588e7
Compare
36588e7 to
8a73908
Compare
|
Alright, this has been refactored a large amount of times and tested to be working, so it should be fully ready now! |
|
The Python bot seems to run on Wednesday at midnight, so we have time before that old one runs. I'm assuming I should do a Docker stop on the Python version so we don't end up double posting to the various Slack channels, correct? |
|
@allela yes that's correct |
This is heavily based on #540 but should take us all the way to a fully working slack bot implementation. Thank you @bogdankharchenko!
In addition, a new worker docker instance will need to be configured to run post refreshes