Skip to content

Port Slack Events Bot into Laravel#570

Merged
bogdankharchenko merged 9 commits intohackgvl:developfrom
oliviasculley:slack-events-bot
Mar 14, 2026
Merged

Port Slack Events Bot into Laravel#570
bogdankharchenko merged 9 commits intohackgvl:developfrom
oliviasculley:slack-events-bot

Conversation

@oliviasculley
Copy link
Copy Markdown
Member

@oliviasculley oliviasculley commented Jul 6, 2025

This is heavily based on #540 but should take us all the way to a fully working slack bot implementation. Thank you @bogdankharchenko!

In addition, a new worker docker instance will need to be configured to run post refreshes

@oliviasculley oliviasculley marked this pull request as draft July 8, 2025 00:43
@oliviasculley
Copy link
Copy Markdown
Member Author

After chatting with @irby, we should probably hash+salt the access tokens like user passwords, and then I think we still need to implement the check_api action to happen automatically every hour, I'll probably do more of that later. However, if someone else has a test setup they're welcome to message me and push to my branch!

@oliviasculley
Copy link
Copy Markdown
Member Author

I had a brain fart, we're probably not going to want to hash the access token, I'll probably just remove that table later since I don't think we're going to need it for anything

Comment thread app-modules/slack-events-bot/README.md
Comment thread app-modules/slack-events-bot/README.md
Comment thread app-modules/slack-events-bot/README.md
Comment thread app-modules/slack-events-bot/README.md
Comment thread .github/workflows/unit-tests.yml Outdated
Comment thread app-modules/slack-events-bot/README.md
Comment thread app-modules/slack-events-bot/src/Http/Controllers/SlackController.php Outdated
Comment thread app-modules/slack-events-bot/README.md
@oliviasculley
Copy link
Copy Markdown
Member Author

So turns out the current implementation working in our workspace might've been a bit misleading, since we were relying on our bot token rather than the installation-specific tokens to access the Slack API. Even though it was working in my testing, I think we need to actually use the installation-specific access tokens for each installation otherwise it would break for other installations, so I need to test this with my current implementation as well.

I'm currently trying to get the tests to pass and this should be ready after that I think

@oliviasculley oliviasculley force-pushed the slack-events-bot branch 2 times, most recently from 0be5cf7 to 0f7f19e Compare July 10, 2025 00:56
@oliviasculley oliviasculley marked this pull request as ready for review July 10, 2025 01:00
Comment thread app-modules/slack-events-bot/README.md Outdated
Comment thread app-modules/slack-events-bot/slackbot-manifest.json Outdated
Comment thread docker-compose.yml Outdated
Comment thread app-modules/slack-events-bot/vendor/autoload.php Outdated
Comment thread app-modules/slack-events-bot/tests/Services/BotServiceTest.php Outdated
Comment thread app-modules/slack-events-bot/tests/Services/AuthServiceTest.php
Comment thread app-modules/slack-events-bot/src/Http/Controllers/SlackController.php Outdated
Comment thread app-modules/slack-events-bot/src/Services/DatabaseService.php
Comment thread .env.docker
Comment thread app-modules/slack-events-bot/src/Http/Controllers/SlackController.php Outdated
@oliviasculley
Copy link
Copy Markdown
Member Author

All the unresolved comments are items that I still need to get to with this PR (or that someone else can get to), but I'll hopefully get to these soon

Copy link
Copy Markdown
Contributor

@irby irby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise I'm fine with everything here.

@oliviasculley oliviasculley force-pushed the slack-events-bot branch 3 times, most recently from f28602a to df68940 Compare October 12, 2025 20:50
Comment thread .tool-versions
Comment thread app-modules/slack-events-bot/routes/web.php
Comment thread app-modules/slack-events-bot/vendor/composer/ClassLoader.php Outdated
Comment thread docs/SLACK_BOT_API.md Outdated
@allella
Copy link
Copy Markdown
Member

allella commented Mar 11, 2026

@oliviasculley

Bogdan has a production server running on Railway that we're going to be testing.

The main thing that I could see holding us up is that we're currently proxying /slack paths for the Slack bot to the localhost container on my old server.

I'm sure we could figure how to temporarily proxy that through a sub-domain, but this PR already aimed to just do away with the Python implementation in favor of built in PHP.

I provided comments on documentation, but I hoped to see if you'd have time to get this one over the finish line if there's anything remaining to be done.

@oliviasculley
Copy link
Copy Markdown
Member Author

I just started paying for the fancy claude code, so I can update this branch and get it in tip top shape soon, but I have some other stuff that I need to get done first

@bogdankharchenko bogdankharchenko marked this pull request as draft March 12, 2026 18:50
@bogdankharchenko
Copy link
Copy Markdown
Collaborator

@oliviasculley great, I am putting this into Draft mode, let me know if you need any help!

@oliviasculley oliviasculley marked this pull request as ready for review March 13, 2026 01:08
@oliviasculley
Copy link
Copy Markdown
Member Author

@bogdankharchenko I think this might be ready now!

@oliviasculley oliviasculley self-assigned this Mar 13, 2026
Comment thread app-modules/slack-events-bot/src/Providers/SlackEventsBotServiceProvider.php Outdated
@oliviasculley oliviasculley marked this pull request as draft March 13, 2026 17:50
@oliviasculley oliviasculley marked this pull request as ready for review March 13, 2026 20:11
@oliviasculley oliviasculley marked this pull request as draft March 13, 2026 20:11
@oliviasculley oliviasculley marked this pull request as ready for review March 13, 2026 20:14
Comment thread README.md
@oliviasculley oliviasculley marked this pull request as draft March 13, 2026 20:48
@oliviasculley oliviasculley force-pushed the slack-events-bot branch 2 times, most recently from 48892c8 to 36588e7 Compare March 13, 2026 21:06
@oliviasculley oliviasculley marked this pull request as ready for review March 14, 2026 01:45
@oliviasculley
Copy link
Copy Markdown
Member Author

Alright, this has been refactored a large amount of times and tested to be working, so it should be fully ready now!

@bogdankharchenko bogdankharchenko merged commit b19e720 into hackgvl:develop Mar 14, 2026
3 of 4 checks passed
@allella
Copy link
Copy Markdown
Member

allella commented Mar 14, 2026

The Python bot seems to run on Wednesday at midnight, so we have time before that old one runs.

I'm assuming I should do a Docker stop on the Python version so we don't end up double posting to the various Slack channels, correct?

@oliviasculley
Copy link
Copy Markdown
Member Author

@allela yes that's correct

@oliviasculley oliviasculley deleted the slack-events-bot branch March 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants