docs: add documentation for harvester-node-disk-manager ConfigMap#975
docs: add documentation for harvester-node-disk-manager ConfigMap#975Yu-Jack merged 3 commits intoharvester:mainfrom
Conversation
|
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
There was a problem hiding this comment.
Pull request overview
This PR adds new documentation for the harvester-node-disk-manager ConfigMap, which is the recommended way (from Harvester v1.8.0 onwards) to configure disk filtering and auto-provisioning. It also updates the legacy auto-disk-provision-paths setting page to reference the new ConfigMap approach.
Changes:
- New
disk-filter-and-auto-provision.mdpage documenting the ConfigMap-based disk filtering and auto-provisioning feature - Update to
settings.mdadding a version note and a callout block pointing to the new page
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
docs/advanced/disk-filter-and-auto-provision.md |
New documentation page covering ConfigMap location, YAML configuration structure, hostname patterns, filter options, auto-provisioning options, and migration from the legacy setting |
docs/advanced/settings.md |
Adds a **Versions** field and a :::note callout to the auto-disk-provision-paths section directing readers to the new ConfigMap-based approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add new disk-filter-and-auto-provision.md page with complete documentation - Document ConfigMap location, structure, and configuration options - Update settings.md to link to the new documentation page Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
tserong
left a comment
tserong
left a comment
There was a problem hiding this comment.
Good stuff! Just one question about a possible tweak.
|
|
||
| ## Auto-Provisioning Configuration | ||
|
|
||
| The `autoprovision.yaml` section allows you to automatically add disks as VM storage. |
There was a problem hiding this comment.
Is it worth saying here explicitly that it'll be Longhorn V1? Or should we just leave it as-is and update later to talk about different provisioner types, once we add support for autoprovisioning LHv2 and LVM?
There was a problem hiding this comment.
Good catch. I think we should explicitly mention longhorn v1 here.
Signed-off-by: Jack Yu <jack.yu@suse.com>
harvester/harvester#5059