Conversation
There was a problem hiding this comment.
Pull request overview
Adds additional APIv2 CI tests, primarily focused on ACL/list visibility checks and introducing coverage for the ApiToken (JWT API key) resource.
Changes:
- Added ApiToken test object creation support and a new
ApiTokentest suite (including token-field behavior checks). - Introduced a shared ACL list-visibility helper plus multiple
test_aclcases across existing model tests. - Cleaned up a couple of unused imports in existing tests.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ci/apiv2/utils.py | Adds ApiToken test-object creation, restricted-user helper, and a reusable ACL list-visibility assertion helper. |
| ci/apiv2/testfiles/apitoken/create_apitoken_001.json | Adds JSON payload fixture for creating an ApiToken in tests. |
| ci/apiv2/test_apitoken.py | New test suite for ApiToken CRUD/behavior (token returned only on create, ACL list behavior, etc.). |
| ci/apiv2/test_taskwrapper.py | Adds ACL list test for TaskWrapper. |
| ci/apiv2/test_task.py | Adds ACL list test for Task. |
| ci/apiv2/test_hashlist.py | Adds ACL list test for Hashlist. |
| ci/apiv2/test_file.py | Adds ACL list test for File. |
| ci/apiv2/test_agentstat.py | Adds ACL list test for AgentStat. |
| ci/apiv2/test_agentassignment.py | Removes unused import and adds ACL list test for AgentAssignment. |
| ci/apiv2/test_agent.py | Adds ACL list test for Agent. |
| ci/apiv2/test_pretask.py | Removes unused import. |
| ci/apiv2/test_hash.py | Removes unused import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
April 29, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashtopolis/python-hashtopolis#2 should be merged first otherwise tests cannot pass