1161 bug new api duplicate links object in get one api responses#2054
Open
1161 bug new api duplicate links object in get one api responses#2054
Conversation
Author
|
The change in the api (no self reference inside the data entity) break the implementation of python-hashtopolis that relies on that one when creating objects. I will check if there is a way to implement a backward compatible fix, otherwise I would appreciate some guidance on how to move forward with this one. |
Contributor
|
I have looked at the code and I think it might be better after all to keep the duplicate uri. it is only for getOne requests and by keeping it it is easier for clients to use the api and not have to switch between to many to one cases. Just like we see now in the hashtopolis.py case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractBaseAPI::obj2ResourcetoAbstractModelAPI::getManyResourcestest_http_methods.pyI have made some manual testing in the web-ui and cant see that anything breaks with the change.
@jessevz, please add other reviewer as you see fit.