Add a few basic tests for unboxing and RULES working#714
Open
clyring wants to merge 4 commits intohaskell:masterfrom
Open
Add a few basic tests for unboxing and RULES working#714clyring wants to merge 4 commits intohaskell:masterfrom
clyring wants to merge 4 commits intohaskell:masterfrom
Conversation
This uses tasty-inspection-testing, which is a plugin and so introduces a circular dependency: bytestring -> plugin -> ghc -> bytestring This is worked around with an ugly but simple hack: Guard the part of the testsuite that uses the plugin behind a flag, and change the name of the (local) package before trying to build the testsuite with that flag enabled.
Bodigrim
reviewed
Sep 12, 2025
bytestring.cabal
Outdated
| default: False | ||
| manual: True | ||
|
|
||
| Flag plugin-tests |
Contributor
There was a problem hiding this comment.
This is somewhat suboptimal, because Hackage won't have any idea that this is an internal flag for tests only and will proudly advertise the flag to everyone. Given that we hack the Cabal file anyway, could we insert build-depends and other-modules as a part of shell script too?
Bodigrim
reviewed
Sep 14, 2025
| @@ -0,0 +1,45 @@ | |||
| {-# LANGUAGE TemplateHaskellQuotes #-} | |||
|
|
|||
| module PluginTests.Splices where | |||
Contributor
There was a problem hiding this comment.
Could you please add an explicit export list?
| , (`doesNotUseAnyOf` unpackCString_functions_all) | ||
| ] | ||
|
|
||
| hasNoStringyStuffExceptFolds :: Name -> Q Exp |
Contributor
There was a problem hiding this comment.
This one seems unused anywhere?
Bodigrim
reviewed
Oct 2, 2025
| @@ -0,0 +1,14 @@ | |||
| # small script to hackily work around the dependency cycle | |||
Contributor
There was a problem hiding this comment.
How do you feel about chmod +x on this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
tasty-inspection-testing, whichisneeds a plugin and so introduces a circular dependency:This is worked around with an ugly but simple hack: Guard the part of the testsuite that uses the plugin behind a flag, and change the name of the (local) package before trying to build the testsuite with that flag enabled.
(Obviously there are more similar tests that could be added if this works and isn't too repulsive.)