Require Applicative (g s) as a superclass of FieldGrammar#11821
Require Applicative (g s) as a superclass of FieldGrammar#11821Bodigrim wants to merge 1 commit into
Conversation
Thus acting on the old todo, which helps a little bit with boilerplate.
| {-# LANGUAGE ConstraintKinds #-} | ||
| {-# LANGUAGE FunctionalDependencies #-} | ||
| {-# LANGUAGE KindSignatures #-} | ||
| {-# LANGUAGE QuantifiedConstraints #-} |
There was a problem hiding this comment.
Do we need quantified constraints? I just removed these because it doesn't work well with type families in my exact print prototype.
There was a problem hiding this comment.
We would not be able to constrain FieldGrammar by forall s. Applicative (g s) without {-# LANGUAGE QuantifiedConstraints #-} enabled. Why does it mess up your type families?
(This PR is just a quality-of-life thing, I'm prepared to abandon it if it gets in the way of more important projects)
There was a problem hiding this comment.
My bad, I just tried to apply your changes here to exact print prototype and it worked fine. Last time I had trouble with QuantifiedConstraints was because the quantified constraint was a type family, which GHC can't deal with. In this case s is not a type family.
It's all good for me :)
I think we can finally act on the old TODO, cutting a bit of boilerplate.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.