-
Notifications
You must be signed in to change notification settings - Fork 99
Make it compile with MicroHs #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: ci-mhs | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] | ||
|
|
||
| jobs: | ||
| build-mhs-mtl: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
| - name: checkout mhs repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: augustss/MicroHs | ||
| ref: stable-6 | ||
| path: mhs | ||
| - name: make and install mhs | ||
| run: | | ||
| cd mhs | ||
| make minstall | ||
|
|
||
| - name: checkout transformers repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: augustss/transformers | ||
| path: transformers | ||
| - name: compile and install transformers package | ||
| run: | | ||
| PATH="$HOME/.mcabal/bin:$PATH" | ||
| cd transformers | ||
| mcabal install | ||
|
|
||
| - name: checkout mtl repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: augustss/mtl | ||
| path: mtl | ||
| - name: compile and install mtl package | ||
| run: | | ||
| PATH="$HOME/.mcabal/bin:$PATH" | ||
| cd mtl | ||
| mcabal install | ||
|
|
||
| - name: checkout parsec repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: parsec | ||
| - name: compile and install parsec package | ||
| run: | | ||
| PATH="$HOME/.mcabal/bin:$PATH" | ||
| cd parsec | ||
| mcabal install | ||
|
|
||
| - name: cleanup | ||
| run: | | ||
| rm -rf $HOME/.mcabal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually dropped the support for pre GHC-8.0, so this conditional's else-branch can be removed. Do you mind?
I'm not sure whether Hackage is using new enough
Cabalto acceptimpl(mhs).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the else branch if you want.
Cabal accepts mhs as a valid compiler now, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Maybe the CI is using some older cabal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer
Cabaldoes. Buthackage-serverstill uses oldCabal, so this change could not be released. (And it might take quite a long time).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment Hackage uses Cabal 3.12.1.0, which knows about MHS:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bodigrim good to know. But given a thought, if the thing can be written without
impl(mhs), it should.You help me, I help you. I'm sorry, but I don't care about
MicroHS, so if I can be unaware I will.That said, the first moment the CI breaks, I will remove it; so adding CI for microhs is somewhat unnecessary too. I won't put any effort into it.
TL;DR my stance is: GHC is the only compiler out there. The ship for multi-compiler ecosystem has long sailed away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no support for pre-8.0 GHC then the condition can be simplified and it will work with MicroHs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started this discussion with saying
This left a bad taste. I removed the conditional, so AFAICT this patch has only
MonoLocalBindschanges which are relevant.