Conversation
The interaso/webpush library decodes p256dh/auth keys with URL-safe Base64 (Base64.getUrlDecoder) but the frontend encoded them with btoa() which produces standard Base64. Keys containing + or / caused silent decode failures, preventing all push notifications from being delivered. Also pass deviceId as a query parameter on mutation requests instead of the X-Device-Id header (which was removed earlier due to CORS preflight failures), so the backend can exclude the originating device from self-notifications.
…h opt-out Replace generic 'List updated' notifications with action-specific messages (added, checked, unchecked, edited, deleted, cleared). Auto-subscribe users on list open with per-list opt-out stored in localStorage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(now passed as query param)
deleted (✕), and completed items cleared
Changes
Backend
ITEM_DELETED, ITEMS_CLEARED) and descriptive notification titles/bodies
read deviceId from query param instead of header
Frontend
shoppimo_push_optout_{listId})
state shows gray styling