Displaying approved PHEPs; include PHEP-1#328
Merged
sapols merged 10 commits intoheliophysicsPy:mainfrom May 20, 2024
Merged
Conversation
Contributor
Contributor
Author
|
That's probably actually more clear. Thanks for getting that working. I'll poke around and see what I can do about including DOI. |
Contributor
Author
|
I just pushed an update to heliophysicsPy/standards#26 that inserts the DOI into the YAML, so we will want an additional column. I'm thinking at the very end (after revision) and then: |
Contributor
|
I'll note that for the DOI to display properly in the table, the |
Contributor
Contributor
Author
|
Just to note, once heliophysicsPy/standards#22 is merged and the release cut, I will finish the Zenodo upload and mark this ready to merge. |
Contributor
Author
|
Zenodo is uploaded, so @sapols , ready to merge! |
sapols
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a terrible first shot at displaying approved pheps, by someone who really doesn't understand Jekyll :) but hopefully it can get the idea across. It's sort of the complement to heliophysicsPy/standards#26 ...that has a Python snippet which extracts the necessary yaml, and this then just dumps the YAML, more-or-less. Untested.
Maybe we should have the DOI in there somewhere, too.