Skip to content

test(cli): make User-Agent REST config test hermetic #31907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LarytheLord wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(cli): make User-Agent REST config test hermetic #31907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3629ef6
test(cli): isolate user-agent rest config test from host kubeconfig
LarytheLord Mar 5, 2026
47d2353
test(cli): use t.Cleanup for resetEnv with t.Setenv
LarytheLord Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions pkg/cli/environment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package cli

import (
"os"
"path/filepath"
"reflect"
"strings"
"testing"
Expand Down Expand Up @@ -122,7 +123,8 @@ func TestEnvSettings(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
defer resetEnv()()
cleanup := resetEnv()
t.Cleanup(cleanup)

for k, v := range tt.envvars {
t.Setenv(k, v)
Expand Down Expand Up @@ -243,7 +245,32 @@ func TestEnvOrBool(t *testing.T) {
}

func TestUserAgentHeaderInK8sRESTClientConfig(t *testing.T) {
defer resetEnv()()
cleanup := resetEnv()
t.Cleanup(cleanup)

kubeconfigPath := filepath.Join(t.TempDir(), "config")
kubeconfig := `apiVersion: v1
clusters:
- cluster:
server: https://127.0.0.1:6443
name: test
contexts:
- context:
cluster: test
user: test-user
name: test
current-context: test
kind: Config
preferences: {}
users:
- name: test-user
user:
token: test-token
`
if err := os.WriteFile(kubeconfigPath, []byte(kubeconfig), 0o600); err != nil {
t.Fatalf("failed to create test kubeconfig: %v", err)
}
t.Setenv("KUBECONFIG", kubeconfigPath)

settings := New()
restConfig, err := settings.RESTClientGetter().ToRESTConfig()
Expand Down