Conversation
Contributor
Author
|
@EvanDietzMorris I have deleted the separate memgraph deployment helm chart and integrated memgraph deployment into Plater deployment helm chart. I tested out each of the four options locally: (1) memgraph; (2) neo4j; (3) external memgraph; (4) external neo4j; and everything appears to work based on my testing. So now it is ready for you to test and code review the PR. Let me know if you notice any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@EvanDietzMorris This PR is for adding memgraph KG deployment helm chart. I tested it out locally and it works, but let me know if you see any issues with the helm chart which will be deployed in the ITRB environment. I've asked you to code review this PR.