test: migrate CI and Certificate tests to @oclif/test v4 (PR 6/11)

[eablack]

This PR is part of a series migrating test files from @oclif/test v2 to v4 following the package upgrade in the foundation PR. This is PR 6 of 11 in the incremental migration plan.

Description

Migrates 12 test files in the CI Commands and Certificates category to be compatible with @oclif/test v4.1.15, including tests for CI configuration, CI test runs, and SSL certificate management.

Files Migrated (12 total)

CI Config Tests (4 files):

• test/unit/commands/ci/config/get.unit.test.ts (2 tests)
• test/unit/commands/ci/config/index.unit.test.ts (4 tests)
• test/unit/commands/ci/config/set.unit.test.ts (3 tests)
• test/unit/commands/ci/config/unset.unit.test.ts (2 tests)

CI Command Tests (6 files):

• test/unit/commands/ci/index.unit.test.ts (6 tests)
• test/unit/commands/ci/info.unit.test.ts (7 tests)
• test/unit/commands/ci/last.unit.test.ts (5 tests)
• test/unit/commands/ci/migrate-manifest.unit.test.ts (2 tests)
• test/unit/commands/ci/rerun.unit.test.ts (3 tests)
• test/unit/commands/ci/run.unit.test.ts (3 tests)

Certificate Tests (2 files):

• test/unit/commands/certs/add.unit.test.ts (10 tests)
• test/unit/commands/certs/generate.unit.test.ts (9 tests)

Total: 56 tests migrated ✅

Migration Changes

All tests were updated to use the new @oclif/test v4 API:

Before (v2):

test
  .stdout()
  .nock('https://api.heroku.com', api => api
    .get('/pipelines?eq[name]=example')
    .reply(200, [{id: '123'}])
  )
  .command(['ci', '--pipeline', 'example'])
  .it('shows test runs', ctx => {
    expect(ctx.stdout).to.contain('test run')
  })

After (v4):

it('shows test runs', async () => {
  nock('https://api.heroku.com')
    .get('/pipelines?eq[name]=example')
    .reply(200, [{id: '123'}])

  await runCommand(Cmd, ['--pipeline', 'example'])

  expect(stdout.output).to.contain('test run')
})

Key Pattern Changes

1. API: Replaced chaining test API with runCommand() function
2. Async: Converted callback-style tests to async/await
3. Output: Use stdout.output and stderr.output from stdout-stderr package
4. Error Handling: Check error?.oclif?.exit property for exit codes
5. Cleanup: Added afterEach(() => nock.cleanAll()) hooks
6. Nock Setup: Moved nock setup inside each test for better isolation

Special Changes

ES Module Stubbing Solution

For tests requiring stubs of ES module exports (which Sinon cannot stub directly), we implemented a service wrapper pattern:

Created wrapper classes in source files:

• GitService in src/lib/ci/git.ts - wraps git operations
• FileService in src/lib/ci/source.ts - wraps file operations

Updated source code to use service instances:

// src/lib/ci/source.ts
const gitService = new GitService()
const fileService = new FileService()

export async function createSourceBlob(ref: any, command: Command) {
  const githubRepository = await gitService.githubRepository()
  const filePath = await gitService.createArchive(ref)
  // ...
}

export {gitService, fileService}

Tests now stub service methods:

import {gitService, fileService} from '../../../../src/lib/ci/source.js'

beforeEach(() => {
  sandbox.stub(gitService, 'createArchive').resolves('archive.tgz')
  sandbox.stub(fileService, 'stat').resolves({size: 500})
})

Test Isolation Fix

Fixed test isolation issue in certs/generate.unit.test.ts where a test-specific nock mock was being overridden by the beforeEach mock. Added nock.cleanAll() before setting up test-specific mocks to ensure proper isolation.

Testing

• ✅ All 56 migrated tests pass locally
• ✅ Tests pass in CI
• ✅ No regressions in other test suites
• ✅ Build passes

Related

• Part of the @oclif/test v2 → v4 migration plan outlined in OCLIF_TEST_UPGRADE_PR_PLAN.md
• Follows foundation PR test: upgrade @oclif/test to v4 #3447 that upgraded the package version

[michaelmalave]

Changes look good and complete for ci and certificate!