feat: update accounts:set to work with keychain managers#3696
Open
k80bowman wants to merge 4 commits intofeat/credential-mgr-integrationfrom
Open
feat: update accounts:set to work with keychain managers#3696k80bowman wants to merge 4 commits intofeat/credential-mgr-integrationfrom
k80bowman wants to merge 4 commits intofeat/credential-mgr-integrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
accounts:setcommand to work with keychain managers.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
npm i && npm run build./bin/run loginto log in to your first account.heroku accounts:add account1to add this account to your accounts cache for .netrc./bin/run loginto log in to your second accountheroku accounts:add account2to add this second account to your accounts cache for .netrcSteps:
./bin/run accounts:set <username for account 1>./bin/run appsand you should see the apps for account 1./bin/run accounts:set <username for account 2>./bin/run appsand you should see the apps for account 2HEROKU_NETRC_WRITE=true ./bin/run accounts:set account1HEROKU_NETRC_WRITE=true ./bin/run appsand you should see the apps for account 1HEROKU_NETRC_WRITE=true ./bin/run accounts:set account2HEROKU_NETRC_WRITE=true ./bin/run appsand you should see the apps for account 2Screenshots (if applicable)
Related Issues
GUS work item: W-20867209