fix: validate HEROKU_HOST for container registry commands#3704
Open
michaelmalave wants to merge 3 commits into
Open
fix: validate HEROKU_HOST for container registry commands#3704michaelmalave wants to merge 3 commits into
michaelmalave wants to merge 3 commits into
Conversation
…o use validated vars.host
…s rejected and the command falls back to registry.heroku.com
…e scoped setup/teardown contexts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch hardens container command registry host resolution by switching from raw
HEROKU_HOSTusage to validated host configuration, preventing invalid domains from being used in registry calls. It also adds regression coverage to ensure invalid host input falls back safely toregistry.heroku.comwith a user-visible warning.process.env.HEROKU_HOSTregistry host construction withvars.hostincontainer:login,container:logout,container:pull,container:push,container:release, andcontainer:runcontainer:loginandcontainer:logoutverifying invalidHEROKU_HOSTis rejected and fallback registry is usedcontainer:releaseverifying registry manifest requests still targetregistry.heroku.comwhenHEROKU_HOSTis invalidType of Change
Verification
CI Passes
Additional Context
Related Issue
W-21981314