Skip to content

fix: migrate release scripts from qqjs to script-exec helpers#3707

Merged
michaelmalave merged 1 commit into
mainfrom
mm/fix/migrate-release-scripts-to-script-exec-helpers
May 13, 2026
Merged

fix: migrate release scripts from qqjs to script-exec helpers#3707
michaelmalave merged 1 commit into
mainfrom
mm/fix/migrate-release-scripts-to-script-exec-helpers

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

Summary

Removes a release-time regression by migrating the remaining qqjs-based scripts to the shared script-exec helpers, aligning release automation with the repo’s execa migration. This scope is limited to packaging/upload scripts used by prerelease/release flows.

  • Migrate scripts/upload/deb from qqjs to run/x/shell in scripts/utils/script-exec.js
  • Migrate scripts/release/win from qqjs to run/x/shell in scripts/utils/script-exec.js
  • Remove legacy qqjs execution calls and switch to argument-safe x('./node_modules/.bin/oclif', [...]) usage
  • Fix prerelease packaging failure in pack-upload / upload-deb-and-tarballs caused by missing qqjs at runtime

Type of Change

  • fix: Bug fix or issue (patch semvar update)
  • feat: Introduces a new feature to the codebase (minor semvar update)
  • perf: Performance improvement
  • docs: Documentation only changes
  • tests: Adding missing tests or correcting existing tests
  • chore: Code cleanup tasks, dependency updates, or other changes

Verification

npm ci
npm run lint
# Optional targeted script smoke checks
node ./scripts/upload/deb
node ./scripts/release/win
# Full validation via CI path
# Trigger start-prerelease and confirm:
# create-prerelease / pack-upload / upload-deb-and-tarballs succeeds

Additional Context

  • Root cause: scripts/upload/deb and scripts/release/win still imported qqjs after qqjs was removed in the execa migration commit.
  • Risk: low; behavior is preserved while swapping execution helpers.
  • Breaking: none.

…/release/win) from qqjs to the shared script-exec (run/x/shell) helpers so release packaging no longer depends on the removed qqjs package
@michaelmalave michaelmalave requested a review from a team as a code owner May 13, 2026 19:12
@michaelmalave michaelmalave merged commit dcbaa1b into main May 13, 2026
17 checks passed
@michaelmalave michaelmalave deleted the mm/fix/migrate-release-scripts-to-script-exec-helpers branch May 13, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants