fix: migrate release scripts from qqjs to script-exec helpers#3707
Merged
michaelmalave merged 1 commit intoMay 13, 2026
Merged
Conversation
…/release/win) from qqjs to the shared script-exec (run/x/shell) helpers so release packaging no longer depends on the removed qqjs package
k80bowman
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a release-time regression by migrating the remaining
qqjs-based scripts to the sharedscript-exechelpers, aligning release automation with the repo’s execa migration. This scope is limited to packaging/upload scripts used by prerelease/release flows.scripts/upload/debfromqqjstorun/x/shellinscripts/utils/script-exec.jsscripts/release/winfromqqjstorun/x/shellinscripts/utils/script-exec.jsqqjsexecution calls and switch to argument-safex('./node_modules/.bin/oclif', [...])usagepack-upload / upload-deb-and-tarballscaused by missingqqjsat runtimeType of Change
Verification
# Optional targeted script smoke checks node ./scripts/upload/deb node ./scripts/release/winAdditional Context
scripts/upload/debandscripts/release/winstill importedqqjsafterqqjswas removed in the execa migration commit.