Skip to content

fix: ensure go binaries have vcs information #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jooola wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: ensure go binaries have vcs information #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Login to DockerHub
uses: docker/login-action@v4
Expand Down
5 changes: 4 additions & 1 deletion .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
version: 2
before:
hooks:
- go mod tidy
- ./scripts/completions.sh
- go run ./scripts manpages

# https://goreleaser.com/cookbooks/build-go-modules/#building-go-modules
gomod:
proxy: true
Comment on lines +7 to +9
Copy link
Member

@apricote apricote Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link mentions under "Limitations":

VCS info will not be available.

This conflicts the PR title

Copy link
Member Author

@jooola jooola Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the docs for this is confusing. Though Github issues seem to point to this documentation to fix this particular case.

I need to test this locally.


builds:
- <<: &build_defaults
main: ./cmd/hcloud/main.go
Expand Down
Loading