Skip to content

test: refactor e2e test suite #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasmetzner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: refactor e2e test suite #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 60 additions & 51 deletions tests/e2e/cloud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
Expand All @@ -25,12 +26,10 @@ import (
func TestNodeSetCorrectNodeLabelsAndIPAddresses(t *testing.T) {
t.Parallel()

ctx := context.Background()

node, err := testCluster.k8sClient.CoreV1().Nodes().Get(ctx, testCluster.ControlNodeName(), metav1.GetOptions{})
node, err := testCluster.k8sClient.CoreV1().Nodes().Get(t.Context(), testCluster.ControlNodeName(), metav1.GetOptions{})
assert.NoError(t, err)

server, _, err := testCluster.hcloud.Server.Get(ctx, testCluster.ControlNodeName())
server, _, err := testCluster.hcloud.Server.Get(t.Context(), testCluster.ControlNodeName())
if err != nil {
return
}
Expand Down Expand Up @@ -77,52 +76,58 @@ func TestServiceLoadBalancersMinimalSetup(t *testing.T) {
t: t,
podName: "loadbalancer-minimal",
}
t.Cleanup(func() {
lbTest.TearDown()
})

pod := lbTest.DeployTestPod()
pod, err := lbTest.DeployTestPod()
require.NoError(t, err)

lbSvc := lbTest.ServiceDefinition(pod, map[string]string{
string(annotation.LBLocation): "nbg1",
})

lbSvc, err := lbTest.CreateService(lbSvc)
if assert.NoError(t, err, "deploying test svc") {
WaitForHTTPAvailable(t, lbSvc.Status.LoadBalancer.Ingress[0].IP, false)
}
lbSvc, err = lbTest.CreateService(lbSvc)
require.NoError(t, err)

lbTest.TearDown()
err = lbTest.WaitForHTTPAvailable(lbSvc.Status.LoadBalancer.Ingress[0].IP, false)
require.NoError(t, err)
}

func TestServiceLoadBalancersHTTPS(t *testing.T) {
t.Parallel()

cert := testCluster.CreateTLSCertificate(t, "loadbalancer-https")
lbTest := lbTestHelper{
t: t,
podName: "loadbalancer-https",
port: 443,
}
t.Cleanup(func() {
lbTest.TearDown()
})

cert, err := testCluster.CreateTLSCertificate(t, "loadbalancer-https")
require.NoError(t, err)

pod := lbTest.DeployTestPod()
pod, err := lbTest.DeployTestPod()
require.NoError(t, err)

lbSvc := lbTest.ServiceDefinition(pod, map[string]string{
string(annotation.LBLocation): "nbg1",
string(annotation.LBSvcHTTPCertificates): cert.Name,
string(annotation.LBSvcProtocol): "https",
})

lbSvc, err := lbTest.CreateService(lbSvc)
if assert.NoError(t, err, "deploying test svc") {
WaitForHTTPAvailable(t, lbSvc.Status.LoadBalancer.Ingress[0].IP, true)
}
lbSvc, err = lbTest.CreateService(lbSvc)
require.NoError(t, err)

lbTest.TearDown()
err = lbTest.WaitForHTTPAvailable(lbSvc.Status.LoadBalancer.Ingress[0].IP, false)
require.NoError(t, err)
}

func TestServiceLoadBalancersHTTPSWithManagedCertificate(t *testing.T) {
t.Parallel()

ctx := context.Background()

if testCluster.certDomain == "" {
t.Skip("Skipping because CERT_DOMAIN is not set")
}
Expand All @@ -133,8 +138,12 @@ func TestServiceLoadBalancersHTTPSWithManagedCertificate(t *testing.T) {
podName: "loadbalancer-https",
port: 443,
}
t.Cleanup(func() {
lbTest.TearDown()
})

pod := lbTest.DeployTestPod()
pod, err := lbTest.DeployTestPod()
require.NoError(t, err)

lbSvc := lbTest.ServiceDefinition(pod, map[string]string{
string(annotation.LBLocation): "nbg1",
Expand All @@ -144,62 +153,62 @@ func TestServiceLoadBalancersHTTPSWithManagedCertificate(t *testing.T) {
string(annotation.LBSvcHTTPManagedCertificateUseACMEStaging): "true",
})

lbSvc, err := lbTest.CreateService(lbSvc)
if assert.NoError(t, err, "deploying test svc") {
certs, err := testCluster.hcloud.Certificate.AllWithOpts(ctx, hcloud.CertificateListOpts{
ListOpts: hcloud.ListOpts{
LabelSelector: fmt.Sprintf("%s=%s", hcops.LabelServiceUID, lbSvc.ObjectMeta.UID),
},
})
assert.NoError(t, err)
if assert.Len(t, certs, 1) {
testCluster.certificates.Add(certs[0].ID)
}
}
lbSvc, err = lbTest.CreateService(lbSvc)
require.NoError(t, err)

lbTest.TearDown()
certs, err := testCluster.hcloud.Certificate.AllWithOpts(t.Context(), hcloud.CertificateListOpts{
ListOpts: hcloud.ListOpts{
LabelSelector: fmt.Sprintf("%s=%s", hcops.LabelServiceUID, lbSvc.ObjectMeta.UID),
},
})
assert.NoError(t, err)
if assert.Len(t, certs, 1) {
testCluster.certificates.Add(certs[0].ID)
}
}

func TestServiceLoadBalancersWithPrivateNetwork(t *testing.T) {
t.Parallel()

lbTest := lbTestHelper{t: t, podName: "loadbalancer-private-network"}
t.Cleanup(func() {
lbTest.TearDown()
})

pod := lbTest.DeployTestPod()
pod, err := lbTest.DeployTestPod()
require.NoError(t, err)

ipRange := &net.IPNet{
IP: net.IPv4(10, 0, 0, 0),
Mask: net.CIDRMask(24, 32),
}

lbSvcDefinition := lbTest.ServiceDefinition(pod, map[string]string{
lbSvc := lbTest.ServiceDefinition(pod, map[string]string{
string(annotation.LBLocation): "nbg1",
string(annotation.LBUsePrivateIP): "true",
string(annotation.PrivateSubnetIPRange): ipRange.String(),
})

lbSvc, err := lbTest.CreateService(lbSvcDefinition)
if assert.NoError(t, err, "deploying test svc") {
WaitForHTTPAvailable(t, lbSvc.Status.LoadBalancer.Ingress[0].IP, false)
lbSvc, err = lbTest.CreateService(lbSvc)
require.NoError(t, err)

anyInIPRange := slices.ContainsFunc(lbSvc.Status.LoadBalancer.Ingress, func(ingress corev1.LoadBalancerIngress) bool {
ip := net.ParseIP(ingress.IP)
if ip == nil {
return false
}
return ipRange.Contains(ip)
})

assert.True(t, anyInIPRange)
}
err = lbTest.WaitForHTTPAvailable(lbSvc.Status.LoadBalancer.Ingress[0].IP, false)
require.NoError(t, err)

lbTest.TearDown()
anyInIPRange := slices.ContainsFunc(lbSvc.Status.LoadBalancer.Ingress, func(ingress corev1.LoadBalancerIngress) bool {
ip := net.ParseIP(ingress.IP)
if ip == nil {
return false
}
return ipRange.Contains(ip)
})
assert.True(t, anyInIPRange)
}

func TestRouteNetworksPodIPsAreAccessible(t *testing.T) {
t.Parallel()

err := wait.PollUntilContextTimeout(context.Background(), 1*time.Second, 2*time.Minute, true, func(ctx context.Context) (bool, error) {
err := wait.PollUntilContextTimeout(t.Context(), 1*time.Second, 2*time.Minute, true, func(ctx context.Context) (bool, error) {
node, err := testCluster.k8sClient.CoreV1().Nodes().Get(ctx, testCluster.ControlNodeName(), metav1.GetOptions{})
if err != nil {
return false, err
Expand All @@ -222,6 +231,6 @@ func TestRouteNetworksPodIPsAreAccessible(t *testing.T) {
return false, nil
})
if err != nil {
t.Fatal(err)
t.Errorf("error waiting for pod IPs being accessible: %v", err)
}
}
5 changes: 2 additions & 3 deletions tests/e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package e2e

import (
"context"
"fmt"
"os"
"strings"
Expand Down Expand Up @@ -34,7 +33,7 @@ func TestPodIsPresent(t *testing.T) {
t.Parallel()

t.Run("hcloud-cloud-controller-manager pod is present in kube-system", func(t *testing.T) {
pods, err := testCluster.k8sClient.CoreV1().Pods("kube-system").List(context.Background(), metav1.ListOptions{})
pods, err := testCluster.k8sClient.CoreV1().Pods("kube-system").List(t.Context(), metav1.ListOptions{})
assert.NoError(t, err)

found := false
Expand All @@ -51,7 +50,7 @@ func TestPodIsPresent(t *testing.T) {

t.Run("pod with app=hcloud-cloud-controller-manager is present in kube-system", func(t *testing.T) {
pods, err := testCluster.k8sClient.CoreV1().Pods("kube-system").
List(context.Background(), metav1.ListOptions{
List(t.Context(), metav1.ListOptions{
LabelSelector: "app.kubernetes.io/name=hcloud-cloud-controller-manager",
})
assert.NoError(t, err)
Expand Down
Loading
Loading