-
Notifications
You must be signed in to change notification settings - Fork 103
feat: account create transaction support private key #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account create transaction support private key #954
Conversation
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
|
Hi, this is WorkflowBot.
|
|
@tech0priyanshu request review if available |
af4c1c3 to
54cd7cf
Compare
|
@AntonioCeppellini @exploreriii Everything else looks good to me |
|
@AntonioCeppellini please resolve your merge conflict . For additional help read merge conflict guide . |
96795ca to
5a5d67d
Compare
@tech0priyanshu resolved, thank you! :D |
|
Request review @manishdait if available please |
manishdait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonioCeppellini, Just a small change, Rest looks good to me.
|
@AntonioCeppellini: quick rebase pls and then that's ready to go! Thank you for your contribution |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonioCeppellini
#946
we just merged, therefore, please refactor to use the utils 👍
…both PublicKey and PrivateKey, added unit and integration tests Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
… removed typo error Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
…h public and private Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
d8546a0 to
c3bdcb2
Compare
|
@exploreriii i have removed the method to get the evm adress that i wrote because i saw that was already implemented in the class |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonioCeppellini I think this is looking great, it may already be enough but it could be worth either in this or a separte issue expanding the test coverage and also adding examples
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
…de duplication Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
Signed-off-by: AntonioCeppellini <128388022+AntonioCeppellini@users.noreply.github.com>
|
Hi @AntonioCeppellini nice work! Merged! I noticed your examples follow a similar style to the other account create alias We should update these examples to be more modular, in my opinion for example, you generally just have a set up client and then one final functionat the end - but that can have lots of different functionality, making it very difficult for a user - wanting examples - to understand how to do each part if you agree, would you be able to help me create a couple of these good first issues (keep to one example per good first issue) to refactor these monolithic examples into more modular functions? for example, pulling out the account info query into its own function <-- also idea for @tech0priyanshu @MonaaEid @Akshat1931 |
Yes, I agree with you, I will help you crate some good first issues :D @exploreriii |
Description:
This PR allows
AccountCreateTransactionto accept bothPrivateKeyandPublicKeylike the other SDKs.PrivateKeyaskeyinAccountCreateTransactionKey = Union[PrivateKey, PublicKey]_to_proto_keyhelper to correctly serializePrivateKeyas its correspondingPublicKey_derive_evm_addresshelper to derive EVM aliases fromPrivateKeyandPublicKeyRelated issue(s):
Fixes #939
Checklist