Draft
Conversation
Project restructuring, dead code removed, unused features removed
Proper HTML parsing, added callbacks, types and stuff
Easier debugging by just removing /tmp/hexdocs_docset_api/static/docsets/* to re-generate new docset
1. Replaced `sqlitex` and `esqlite` with `exqlite`, which seems to be working better and has a slightly nicer syntax. 2. Hacked on builder.ex, builder_server.ex and feed_controller.ex in order to simplify things down for use as a web server and as a task. 3. Improved logging and error reporting logic somewhat
- This version is designed to work with a vanilla Phoenix 1.6 install (I intend to get 1.7 working soon). The destination logic was broken, so I removed it from the build process entirely. Instead it's used when copying the result docset to the destination path: the working directory is kept entirely seperate. - This script can also handle relative directories
- Make `<nixpkgs>` optional as an argument in `default.nix` - Change the src to my fork so that others can try it out using Nix. - Use `default.nix` to define the default package in the flake.
…th some tests I've implemented it in such a way that it should be easy to add more fixture examples edge-cases are found. I want to sample files from the top `n` hex.pm packages to use as fixture data.
The finder for whole files seems to always be the same, so I extracted it into a named function
…ssed If the logger emits the phrase "Could not categorise" within the context of `FileParser.parse/3`, then the test will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.