fix: preserve TextStyle height in text editor input field#732
Closed
faizahmaddae wants to merge 7 commits intohm21:stablefrom
Closed
fix: preserve TextStyle height in text editor input field#732faizahmaddae wants to merge 7 commits intohm21:stablefrom
faizahmaddae wants to merge 7 commits intohm21:stablefrom
Conversation
Removed hardcoded height: 0.0 from the editable TextField's style. This preserves the original height from the TextStyle, ensuring proper alignment between the editable text and its rounded background. Previously, the forced height: 0.0 caused misalignment with fonts that have custom line heights (e.g., Persian/Arabic fonts), resulting in the background not properly fitting the text during editing.
- Added 'shadow': 'sh' to minified keys for compact JSON export
- Added shadow parsing in TextLayer.fromMap() to restore shadow on import
- Added shadow serialization in TextLayer.toMap() and toMapFromReference()
Shadow format in JSON:
{
"shadow": {
"color": <int>,
"blurRadius": <double>,
"offsetX": <double>,
"offsetY": <double>
}
}
This is backward compatible - projects without shadow will continue to work.
- Remove shadows: [] override in text_editor_input.dart that was clearing shadows - Add finalStyle logic in layer_widget_text_item.dart to properly merge textStyle including shadows
Move bodyItems after _buildTextField() in Stack so font size slider stays accessible when text is large and multi-line
- Changed toMap to export all shadows as a list instead of just first - Updated fromMap to parse shadows list with legacy single shadow fallback - Added textHeight property to TextEditorStyle (defaults to 0.0 for centering) - Applied textHeight to text_editor_input style and hintStyle
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The editable TextField in the text editor had a hardcoded
height: 0.0in its style, causing misalignment between the text and its rounded background. This was especially noticeable with fonts that have custom line heights (e.g., Persian/Arabic fonts).Solution
Removed the forced
height: 0.0from the TextField's style, allowing it to preserve the original height from the TextStyle. This ensures proper alignment between the editable text and its background.Changes
lib/features/text_editor/widgets/rounded_background_text/rounded_background_text_field.dartheight: 0.0from the TextField style in_buildEditableText()Testing
Tested with various fonts including Persian fonts with custom line heights. The background now properly wraps the text during editing.