Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| }.freeze | ||
| "x86_64-apple-darwin": {}, | ||
| "x86_64-unknown-linux-gnu": {} | ||
| } |
There was a problem hiding this comment.
Suggestion: .freeze was removed from this constant. Freezing constants prevents accidental mutation at runtime — worth restoring.
Suggested change
| } | |
| }.freeze |
Comment on lines
+49
to
+60
| if OS.mac? && Hardware::CPU.arm? | ||
| bin.install "hotdata" | ||
| end | ||
| if OS.mac? && Hardware::CPU.intel? | ||
| bin.install "hotdata" | ||
| end | ||
| if OS.linux? && Hardware::CPU.arm? | ||
| bin.install "hotdata" | ||
| end | ||
| if OS.linux? && Hardware::CPU.intel? | ||
| bin.install "hotdata" | ||
| end |
There was a problem hiding this comment.
All four branches do the same thing. Since every supported OS/CPU combination installs the same binary, these can be collapsed to a single unconditional call:
Suggested change
| if OS.mac? && Hardware::CPU.arm? | |
| bin.install "hotdata" | |
| end | |
| if OS.mac? && Hardware::CPU.intel? | |
| bin.install "hotdata" | |
| end | |
| if OS.linux? && Hardware::CPU.arm? | |
| bin.install "hotdata" | |
| end | |
| if OS.linux? && Hardware::CPU.intel? | |
| bin.install "hotdata" | |
| end | |
| bin.install "hotdata" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.