feat(auth) Add CLI auth session support#63
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
+115
to
+119
| Session { | ||
| access_token: resp.access_token, | ||
| access_expires_at: now_unix() + resp.expires_in, | ||
| refresh_token, | ||
| refresh_expires_at: now_unix() + refresh_ttl, |
Contributor
There was a problem hiding this comment.
super nit: now_unix() is called twice, so access_expires_at and refresh_expires_at can be computed at slightly different wall-clock instants. Capture it once at the top of the function:
Suggested change
| Session { | |
| access_token: resp.access_token, | |
| access_expires_at: now_unix() + resp.expires_in, | |
| refresh_token, | |
| refresh_expires_at: now_unix() + refresh_ttl, | |
| let now = now_unix(); | |
| Session { | |
| access_token: resp.access_token, | |
| access_expires_at: now + resp.expires_in, | |
| refresh_token, | |
| refresh_expires_at: now + refresh_ttl, | |
| source: source.to_string(), | |
| } |
(not blocking)
Comment on lines
+79
to
+82
| pub fn mask_credential(s: &str) -> String { | ||
| if s.len() > 4 { | ||
| format!("{}...", &s[..4]) | ||
| } else { |
Contributor
There was a problem hiding this comment.
super nit: &s[..4] is byte-indexed and will panic if the first 4 bytes straddle a multi-byte UTF-8 character. Tokens are always ASCII in practice, but the idiomatic Rust form is safer:
Suggested change
| pub fn mask_credential(s: &str) -> String { | |
| if s.len() > 4 { | |
| format!("{}...", &s[..4]) | |
| } else { | |
| format!("{}...", s.chars().take(4).collect::<String>()) |
(not blocking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.