feat(update): Add update command#80
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Review
Blocking Issues
src/update.rs:137andsrc/update.rs:154— the Homebrew formula is namedcliin thehotdata-dev/taptap (perdist-workspace.tomlformula = "cli"and the README install command).brew upgrade hotdatawill fail withError: No formula or cask found for hotdata, so the user-facing guidance directs Homebrew users to a broken command.
Action Required
Replace brew upgrade hotdata with brew upgrade hotdata-dev/tap/cli in both the update-available notice (line 137) and the hotdata update Homebrew message (line 154) so the suggestion matches the install command in the README.
Two non-blocking items left inline (temp dir predictability, optional checksum verification).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.