Skip to content

feat(update): Add update command#80

Merged
pthurlow merged 2 commits into
mainfrom
feat/update-cmd
May 19, 2026
Merged

feat(update): Add update command#80
pthurlow merged 2 commits into
mainfrom
feat/update-cmd

Conversation

@pthurlow
Copy link
Copy Markdown
Collaborator

No description provided.

@sentry
Copy link
Copy Markdown

sentry Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 12.35955% with 156 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/update.rs 10.91% 155 Missing ⚠️
src/main.rs 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread src/update.rs Outdated
Comment thread src/update.rs Outdated
Comment thread src/update.rs Outdated
Comment thread src/update.rs
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Blocking Issues

  • src/update.rs:137 and src/update.rs:154 — the Homebrew formula is named cli in the hotdata-dev/tap tap (per dist-workspace.toml formula = "cli" and the README install command). brew upgrade hotdata will fail with Error: No formula or cask found for hotdata, so the user-facing guidance directs Homebrew users to a broken command.

Action Required

Replace brew upgrade hotdata with brew upgrade hotdata-dev/tap/cli in both the update-available notice (line 137) and the hotdata update Homebrew message (line 154) so the suggestion matches the install command in the README.

Two non-blocking items left inline (temp dir predictability, optional checksum verification).

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All prior blocking issues resolved. The Homebrew formula is now sourced from [package.metadata.hotdata] via build.rs so the README, dist config, and binary all agree. Temp-dir extraction now uses tempfile::TempDir.

@pthurlow pthurlow merged commit 4901e0b into main May 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant