Publish to PyPI on version tag push#5
Merged
Conversation
Add a tag-triggered publish workflow matching sdk-python: build, verify the tag matches pyproject.toml, and upload via PyPI Trusted Publishing.
Comment on lines
+43
to
+52
| - name: Build sdist and wheel | ||
| run: python -m build | ||
|
|
||
| - name: Check distribution metadata | ||
| run: python -m twine check --strict dist/* | ||
|
|
||
| - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5 | ||
| with: | ||
| name: dist | ||
| path: dist/ |
There was a problem hiding this comment.
super nit: there is no CI workflow in this repo, so a tag-push goes straight from "build" to "publish to PyPI" without ever running pytest. Consider adding a test step (e.g. uv sync && uv run pytest) before python -m build, or gate publishing on a separate CI workflow having passed on the tagged commit. Otherwise a broken commit that happens to build cleanly will land on PyPI. (not blocking)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish to PyPIworkflow triggered by version tags matchingv[0-9]*pyproject.toml, build sdist/wheel, and upload via PyPI Trusted PublishingTest plan
hotdata-runtime(GitHub environmentpypi)pyproject.toml, push tag (e.g.git tag v0.1.0 && git push origin v0.1.0)