Conversation
hrbonz
left a comment
hrbonz
left a comment
There was a problem hiding this comment.
Could you also provide a reference to the standard in the README? That helps with reviewing the code
aqi/algos/caqi.py
Outdated
|
|
||
|
|
||
| class AQI(PiecewiseAQI): | ||
| """Implementation of the EPA AQI algorithm. |
There was a problem hiding this comment.
Name or the comment?
Because class name(AQI) seems to be used in get_algo implementation?
python-aqi/aqi/algos/__init__.py
Line 20 in 1de8073
| POLLUTANT_NO2_1H: Decimal('1.'), | ||
| }, | ||
| 'units': { | ||
| POLLUTANT_O3_1H: 'µg/m³', |
There was a problem hiding this comment.
Are those units correct? O3, CO, SO2, NO2 are traditionally measured in ppm/ppb
There was a problem hiding this comment.
aqi/algos/caqi.py
Outdated
| (26, 50), | ||
| (51, 75), | ||
| (76, 100), | ||
| (101, 1000)], |
There was a problem hiding this comment.
I should probably think about adding code to handle open scales like this one. Let me know if you have suggestions here.
There was a problem hiding this comment.
No suggestions yet:)
Interesting thing is that I did not find algorithm for calculating CAQI in https://www.airqualitynow.eu/download/CITEAIR-Comparing_Urban_Air_Quality_across_Borders.pdf
But I checked output of Your algorithm and it matches official measurement in my city.
|
I have updated README with CAQI |
|
Hey, this thread is old but is there any chance of merging this? Thanks |
3 participants
Enabling(24h only) CAQI index calculation