Add header function, axis labels, and tooltip rounding & font sizing#41
Open
isaac-florence wants to merge 5 commits intohrbrmstr:masterfrom
Open
Add header function, axis labels, and tooltip rounding & font sizing#41isaac-florence wants to merge 5 commits intohrbrmstr:masterfrom
isaac-florence wants to merge 5 commits intohrbrmstr:masterfrom
Conversation
Named "header" so would not be a breaking change with the current sg_title function providing a different platform for implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for creating this excellent package, it's just what I've been looking for and more.
I have made some minor, non-breaking additions that I hope will be welcome.
Firstly, there is a new function to provide a title but using a different implementation to the current sg_title function. In order for this to be non-breaking I have called this sg_header. It returns a sg object rather than requiring shiny. It also has no additional imports so I hope is helpful.
Secondly, I have added a number of new parameters to the streamgraph function and JS. This includes rounding the figure shown by the tooltip (default is 10 d.p.), changing the tooltip font size, and adding axis labels.
Grateful for your thoughts