Skip to content

fix!: camelCase wasm bindgen function#15

Merged
Shinigami92 merged 1 commit intomainfrom
fix-camel-case-wasm-bindgen
Mar 18, 2026
Merged

fix!: camelCase wasm bindgen function#15
Shinigami92 merged 1 commit intomainfrom
fix-camel-case-wasm-bindgen

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

@Shinigami92 Shinigami92 commented Mar 15, 2025

Summary by CodeRabbit

  • Refactor
    • Updated JavaScript API naming convention for the content compilation function to use camelCase (compileContent).

@Shinigami92 Shinigami92 self-assigned this Mar 15, 2025
@Shinigami92 Shinigami92 added breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 18, 2025
@Shinigami92 Shinigami92 force-pushed the fix-camel-case-wasm-bindgen branch from e7aa652 to 102cb94 Compare March 16, 2026 21:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4dfbe477-fe0c-4dc8-aeec-e7b5edf73fda

📥 Commits

Reviewing files that changed from the base of the PR and between 50fa49f and 102cb94.

📒 Files selected for processing (1)
  • src/lib.rs

📝 Walkthrough

Walkthrough

The compile_content function's wasm-bindgen attribute is updated to specify a JavaScript binding name of compileContent using js_name. The Rust function signature and implementation remain unchanged; only the generated JavaScript export name is affected.

Changes

Cohort / File(s) Summary
WASM JavaScript Binding
src/lib.rs
Added js_name = "compileContent" to wasm-bindgen attribute, changing the exported JavaScript function name from snake_case to camelCase while preserving Rust function name and behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A name change in the binding night,
From snake to camel, oh what delight!
JavaScript calls now sound more sweet,
The Rust stays true, the binding's neat!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting a wasm-bindgen function name from snake_case to camelCase format.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-camel-case-wasm-bindgen
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

@Shinigami92 Shinigami92 added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 94335ee Mar 18, 2026
5 checks passed
@Shinigami92 Shinigami92 deleted the fix-camel-case-wasm-bindgen branch March 18, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant