linux: show M_PRIV instead of M_SHARE in default columns#1955
linux: show M_PRIV instead of M_SHARE in default columns#1955natoscott merged 2 commits intohtop-dev:mainfrom
Conversation
Replace M_SHARE (SHR) with M_PRIV (PRIV) in the default Main screen columns on Linux. M_PRIV shows the process's private memory (RES - SHR), which is a more actionable metric for understanding per-process memory cost than the shared pages size alone. Also document M_PRIV in the man page. Closes htop-dev#492 Signed-off-by: Evgeny Ugolnikov <evgeny.ugolnik@gmail.com>
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
LGTM. If you are happy to add the PCP change needed, please go ahead with that too (perhaps in a follow-up commit or even separate PR if you prefer).
Apply the same default-column change to the PCP platform for consistency with the Linux defaults updated in the previous commit. Signed-off-by: Evgeny Ugolnikov <evgeny.ugolnik@gmail.com>
|
Added the PCP commit. |
@evelikov that sounds like the metric units may be incorrect - but from a quick look, doesn't seem so - both are in units of KiB. I'll take a close look when I can. It's not a known issue so please go ahead and open that new issue, thanks! |
|
Ah, I see the problem - PR to follow, don't worry about a new issue. |
4 participants
Replaces M_SHARE with M_PRIV in the default Linux Main screen columns, as suggested in #492. M_PRIV (RES - SHR) is a more actionable per-process memory metric than shared pages alone.
M_RESIDENT is kept as it remains the de-facto standard memory column across process viewers. M_SHARE is removed since it becomes redundant with M_PRIV. Users who want either column back can re-add them via the Setup screen (F2).
PCP also exposes M_PRIV but its defaults are left unchanged to keep this PR focused on Linux; happy to extend in a follow-up if desired.
Also documents M_PRIV in the man page.
Tested on Debian aarch64 with a fresh config: PRIV column appears in place of SHR, sorting works, config saves and reloads cleanly.
Closes #492